fix: skip formatting anonymous arguments#24
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix the formatting of anonymous arguments in the logcall procedural macro, specifically addressing arguments generated by the async-trait crate. When async-trait transforms function signatures, it may rename underscore parameters (like _: String) to synthetic parameters starting with __arg. The change adds logic to skip these synthetic parameters when generating log format strings.
- Adds a check to skip arguments whose identifiers start with
__argprefix - Converts identifier to string for prefix checking
- Adds test cases for functions with underscore parameters
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lib.rs | Adds logic to skip async-trait generated parameters (those starting with "__arg") in the format string generation |
| tests/ui/ok/has-no-argument.rs | Adds test case for function with underscore parameter fn g(_: i32) |
| tests/ui/ok/async-trait-underscore.rs | Adds new test file for async-trait usage with underscore parameter in trait implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andylokandy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17